Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Field option profile restrictions #18873

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Custom Field option profile restrictions #18873

wants to merge 9 commits into from
+127 −17

Conversation

cconard96
Copy link
Contributor

Checklist before requesting a review

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

Change some options for custom fields to be based on the user's profile. For example, making the field readonly or hidden for certain profiles.
Selection_403

@cconard96 cconard96 force-pushed the feature/custom_fields_profiles branch from e09ec6c to bb0f58e Compare February 11, 2025 02:21
@cconard96 cconard96 marked this pull request as ready for review February 18, 2025 02:13
@cedric-anne cedric-anne requested a review from orthagh February 18, 2025 12:40
@orthagh
Copy link
Contributor

orthagh commented Feb 18, 2025

As seen together, a few actions are required:

  • remove the slider as it can be confusing
  • there is an annoying empty option appearing when choosing the first profile in the list
  • The width ratio between labels and fields for the native fields modal is too tight on the field side
  • could we have the 2 new fields in the same column (or the same row) when displaying them in the custom fields modal?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orthagh orthagh Awaiting requested review from orthagh

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cconard96 @orthagh